4 ms·
I'm not sure if I have high expectations, became too damn good at it, or this is just a bad designer. So take this as a constructive criticism and I have nothi
by csomar 15y ago
I'm not sure if I have high expectations, became too damn good at it, or this is just a bad designer.
So take this as a constructive criticism and I have nothing against the designer, nor I know him.
I'll begin with the HTML/CSS parts. He is a Web Designer, and not simply a designer; so he should use the best practices
1- Use the HTML5 Doctype
2- Removes unnecessary space (empty lines and spaces). Why the extra bits?
3- JavaScript, I see that you are loading a good chunk of JavaScript in the HEAD and you are loading a bunch of it in the end. For example the Amazon JS file (http://s3.amazonaws.com/new.cetrk.com/pages/scripts/0004/7378.js http://s3.amazonaws.com/new.cetrk.com/pages/scripts/0004/737...) is certainly not usable, and is yet a whole HTTP request.
4- In the JavaScript file (http://images2.bingocardcreator.com/javascripts/bcc-all.js?1134712726044062 http://images2.bingocardcreator.com/javascripts/bcc-all.js?1...), you are loading a ColourPicker and other unused stuff. This is a waste of bandwidth, latency, memory and speed. You don't need JavaScript in your main page, apart from the analytic and maybe A/B testing stuff.
5- Unobtrusive JavaScript. (line 181 of the HTML)
Enough, though there are endless problems with the coding part so don't take this list as an exhaustive review. For the design, it just sucks. I agree that simple designs (K.I.S.S) are better, but they should be crafted. I won't complain much, but here are two snapshots of what I'm talking about
1- http://dl.dropbox.com/u/2777218/shot1.png http://dl.dropbox.com/u/2777218/shot1.png
2- http://dl.dropbox.com/u/2777218/shot2.png http://dl.dropbox.com/u/2777218/shot2.png
Again, take this as a constructive feedback and I have nothing against your business; and what matters finally are the sales/$$$.
Take a look at http://www.premiumpixels.com/ http://www.premiumpixels.com/ if you want to see some carefully crafted designs.
- patio11 15y agoMy designer is totally blameless for any implementation infelicities: I have ultimate control over that and hack the heck out of his HTML/CSS before it hits my pages. Other parts are the way they are simply because, well, we have very different standards for things which should delay shipping. Bits are cheap, my time is expensive, optimizing for bits saved (on my cute little re-demoted-to-hobby project, no less) seems like a poor idea. Similarly, failure to achieve pixel perfection of the price display in Australian dollars is not exactly the kind of thing that would scare me away from a design. You know what would terrify me? "It looks nice -- women generally hate it." That would cause the business to fold like an origami crane. Happily, it doesn't seem to have that problem. I'm generally happy to get feedback, even negative feedback, but as one professional to another your feedback doesn't leave me with the impression "Tie a string around my finger to address this later" because it does not persuasively implicate anything I really care about.
- unreal37 15y agoOne could argue that it affects your Google organic search traffic. The better your HTML, and lighter your Javascript, the more likely the mighty Google will send people to you.
- VMG 15y agoThere might be something to this. The site is #6 for "bingo cards" search on google for me.
- tptacek 15y agoFor whatever it's worth: Patrick's original strategy for ranking (and perhaps still the strategy that accounts for most of his revenue) isn't the Google search [bingo cards]. It's 1000 closely related but technologically distinct searches.
- tptacek 15y agoPatrick, you're the expert here on Google traffic direction: are any of these changes likely to impact your ranking?
- Kesty 15y agoI heard that alot, but haven't actually seen that proven yet. It's a very good excuse to force people on improving their HTML and website speed, but I still would like to see the impact of the Google organic results after only speed improvement and bad HTML fixes.
- bigiain 15y agoOn a tangential note: Though the different alignment of the AUD amount wouldn't even register on my radar - I'm 99% sure the exchange rate you're using _will_ be significant for most of your target market. The AUD has been trading above the USD for many months now - and _everybody_ here who buys _anything_ online knows that. http://www.xe.com/ucc/convert/?Amount=29.95&From=USD&To=AUD http://www.xe.com/ucc/convert/?Amount=29.95&From=USD&... It might be worth revisiting those non-USD prices...
- tptacek 15y agoPatrick bootstrapped himself out of his previous full-time programming job, replacing his salary and then some, in single-digit hours per week, using the OLD DESIGN. You gave a numbered list of good suggestions and wrote the kernel of a detailed, thoughtful comment, but sabotaged it with poor framing and assumptions. I don't care or anything, but for your benefit: this is a nerdly inclination that will serve you very, very poorly in your professional career. HN often has the opposite problem from your comment (a bias towards being "right" even when we're not "correct", such as in civil liberties stories); here, you're "correct" but not "right", since adoption of all your recommendations is unlikely to change the bottom line for Patrick at all. One consultant to (I presume) another: my suggestion for next time: either: (a) (expensively) do exhaustive research so you can frame your high-level assessment and recommendations in the context of someone's business (ie, expend the effort to make sure you're both correct and right), or (b) (much simpler) develop a habit of writing your comments in a neutral, helpful tone, so that you can be correct without having to be right at all. By the way, I feel comfortable writing this comment because I have oh my God exactly the same problem with my comments. Look at me on a crypto thread sometime.
- Arelius 15y agoCould you elaborate on what you mean by "correct without having to be write" Within the context of the parent post? Is this a matter of the problems pointed out are "correct" technically, but they may or may not be the "right" thing to spend time on?
- bgilroy26 15y agoJust in case the parent doesn't respond "Is this a matter of the problems pointed out are "correct" technically, but they may or may not be the "right" thing to spend time on?" I'm pretty sure you've already got it, this sounds like it. I would only add that a conscientious person checks whether their comment is adding to the conversation (not anxiously; just subconsciously, as a habit). The parent to your comment is saying that if you're 'correct' you're in the clear that way. I think the thing about being "right" is that if you're right (i.e. your addressee is wrong) you have enough social capital to take that tone with somebody. If you're wrong and you take up an 'I'm right' tone, you come off like you don't care about thinking things through before you make an investment of your time.
- calloc 15y agoNot sure if this is the case or not, but certain templating systems make it really hard to remove extra whitespace/lines (I'm looking at you Jinja2) and they get added when you use standard templating stuff like "if/then" statements. Removing them after the fact with a HTML tidier would work, or you could just not care and let gzip handle the compression.
- irahul 15y ago> Not sure if this is the case or not, but certain templating systems make it really hard to remove extra whitespace/lines (I'm looking at you Jinja2) Jinja2 is a generic templating engine, and as such can't make assumptions about relevance of whitespace. However, writing an extension on top of it isn't hard, and mitsuhiko has written an extension to do that. https://github.com/mitsuhiko/jinja2-htmlcompress https://github.com/mitsuhiko/jinja2-htmlcompress
- calloc 15y agoNice! Going to integrate this into my blogofile setup so that I can output nicer HTML!
- irahul 15y ago> 2- Removes unnecessary space (empty lines and spaces). Why the extra bits? The extra whitespaces are most probably the template output. If he is using erb, erb is a generic template and doesn't make assumptions about relevance of whitespace. If you are optimizing by hand, you will still have all the newlines and indents in the output. Some people use minifiers, most people don't care. Almost all servers and clients speak gzip, and the extra overhead is so low on the list of things to optimize that it probably isn't even on the list. > 3- JavaScript, I see that you are loading a good chunk of JavaScript in the HEAD and you are loading a bunch of it in the end. For example the Amazon JS file (http://s3.amazonaws.com/new.cetrk.com/pages/scripts/0004/737... http://s3.amazonaws.com/new.cetrk.com/pages/scripts/0004/737...) is certainly not usable, and is yet a whole HTTP request. Again, I am taking a guess. layout.html.erb yields under body, and head and scripts are same for all pages. Now patio11 can hand include just the needed scripts on every page, but he chose to include all scripts on all pages. This isn't something the designer controls. > 2- http://dl.dropbox.com/u/2777218/shot2.png http://dl.dropbox.com/u/2777218/shot2.png That menu change really looks weird.
- leon_ 15y agoIn the end: users/customers don't care.
- Sujan 15y agoMaybe Patrick could do a A/B test on the new version of the site vs. the highly optimized version of the new site (do even more than you suggested, there is a lot more possible if you start searching) and see if it makes any difference. That could be really interesting. I doubt he has the time and 'itch' right now, though.