3 ms·
> Because refactoring requires understanding, which LLMs completely lack. Interesting. Here's a sample question I just asked the AI: We are working on a Reac
by ctoth 3y ago
> Because refactoring requires understanding, which LLMs completely lack.
Interesting.
Here's a sample question I just asked the AI:
We are working on a React mapping application.
I am going to give you two components from this application.
Our goal is to extract functionality to deduplicate code
We can make a single base component, extract code to hooks, or any other strategy which you think is appropriate
Here is travel.tsx:
<snip>
Here is heatmap.tsx:
<snip>
And here is the response:
To deduplicate code and improve maintainability between the `TravelMap` and `Heatmap` components in your React mapping application, we can identify common functionalities and extract them into reusable hooks or components. Here's a strategy considering your code:
1. *Extract Common Hooks*: Both components use similar hooks for managing markers, popups, and map references. We can create custom hooks that encapsulate these functionalities.
2. *Create Shared Utility Functions*: Functions like `initialViewState`, which are identical in both components, can be moved to a separate utility file and imported where needed.
3. *Refactor Map Layers and Sources*: The way map layers and sources are handled is quite similar in both components. A custom hook or component to manage map layers and sources would be beneficial.
4. *Generalize Popup Handling*: The popup handling in both components can be abstracted into a custom hook or a higher-order component.
5. *Combine Common Styling*: Shared styles, such as `MAP_CONTAINER_STYLE`, can be moved to a common CSS module or a styled-component that can be reused.
6. *Refactor Event Handlers*: Functions like `onMapClick`, `onMouseMove`, and `onMouseLeave` have similar structures. These can be part of a custom hook or a utility function with configurable parameters.
7. *Legend and Live Region Components*: These components are used in a similar way in both `TravelMap` and `Heatmap`. Ensure they are designed to be reusable with different props.
8. *Refactor Map Initialization*: The way the map is initialized and configured is quite similar. This can be abstracted into a custom component or hook.
### Example Implementations:
#### 1. Custom Hook for Map Markers:
```typescript
// useMapMarkers.ts
import { useState, useCallback } from 'react';
export const useMapMarkers = (initialLat, initialLng, world) => {
// Similar marker logic from your components
// ...
return {
marker,
onMarkerDrag,
onMarkerDragEnd,
updateMarkerPosition,
// other marker related states and functions
};
};
```
#### 2. Shared Utility Function:
```typescript
// utils/mapUtils.ts
export const initialViewState = (map, mapType) => {
// Implementation
};
```
#### 3. Custom Hook for Map Layers and Sources:
```typescript
// useMapLayers.ts
import { useState, useEffect } from 'react';
export const useMapLayers = (props) => {
// Logic to handle layers and sources
// ...
return {
dataLayer,
patternLayer,
// other layer related states and functions
};
};
```
#### 4. Generalized Popup Handling:
```typescript
// useMapPopup.ts
import { useState } from 'react';
export const useMapPopup = () => {
// Popup logic from your components
// ...
return {
popupState,
openPopup,
closePopup,
setPopupData,
// other popup related states and functions
};
};
```
### Integration:
Once these hooks and utilities are created, integrate them into your `TravelMap` and `Heatmap` components. Replace the duplicated logic with calls to these shared resources. This will significantly reduce code duplication and make future maintenance easier.
### Testing and Refinement:
After refactoring, thoroughly test both components to ensure that all functionalities work as expected. Watch out for any edge cases or specific behaviors that might be affected by the refactoring.
For those suggestions, I might use five out of eight of them, and probably do one or two things differently. But you cannot, with a straight face, say the model did not understand. It clearly did. It suggested reasonable refactors. If being able to refactor means understanding, I guess we have understanding!
I could continue with this conversation, ask it to produce the full code for the hooks (I have in my custom prompt to provide outlines) and once the hooks are complete, ask it to rewrite the components using the shared code.
Have you ever used one of these models?
- never_inline 3y agoEliminating duplication and cleaning code is a different type of refactoring than supporting concurrency, which is much much harder. Cleaning up code also follows some well established patterns, performance work is much less pattern-y. Codebases like FFMPEG are one of the kind. I bet you need 10 or 100 times more understanding than the react thing you mentioned above. One day maybe AI can do it, but it probably won't be LLM. It would be something which can understand symbols and math.
- ctoth 3y agoAh, we're having some classic goalpost moving! > Because refactoring requires understanding, which LLMs completely lack. <demonstration that an LLM can refactor code> > Cleaning up code also follows some well established patterns, performance work is much less pattern-y. Just as writing shitty react apps follow patterns, low-level performance and concurrency work also follow patterns. See [0] for a sample. > I bet you need 10 or 100 times more understanding Okay, so a 10 or 100 times larger model? Sounds like something we'll have next year, and certainly within a decade. > One day maybe AI can do it, but it probably won't be LLM. It would be something which can understand symbols and math. You do understand that the reason some of the earlier GPTs had trouble with symbols and math was the tokenization scheme, completely separate from how they work in general, right? [0]: C++ Concurrency in Action: Practical Multithreading 1st Edition https://www.amazon.com/C-Concurrency-Action-Practical-Multithreading/dp/1933988770 https://www.amazon.com/C-Concurrency-Action-Practical-Multit...
- kcbanner 3y ago> Because refactoring requires understanding, which LLMs completely lack. It's obvious from context here that the refactoring that was mentioned was specifically around concurrency, not simply cleaning up code.
- ctoth 3y agoSo if I show you an LLM implementing concurrency, will you concede the point? Is this your true objection? https://chat.openai.com/share/7c41f59a-c21c-4abd-876c-c95647d68026 https://chat.openai.com/share/7c41f59a-c21c-4abd-876c-c95647...