4 ms·
Giant PRs that are squashed into one commit are an anti-pattern. Every commit should contain exactly one logical change AND a descriptive commit message. Unfor
by dolni 3y ago
Giant PRs that are squashed into one commit are an anti-pattern. Every commit should contain exactly one logical change AND a descriptive commit message.
Unfortunately a good chunk of the industry doesn't have the discipline to do this.
If you have ever worked in a project where there was discipline around committing, you know there is lots of value in doing so (rebasing becomes easier, you unlock the power of bisect, log is actually useful).
- argulane 3y agoThis! Also doing PR code review is soo much nicer if each commit is logically self contained with a nice commit message.