6 ms·
This is funny because in PR oriented development I started treating commits in the same way as "save" in IDE, it's just backup of current state with irrelevant
by retpoline__ 3y ago
This is funny because in PR oriented development I started treating commits in the same way as "save" in IDE,
it's just backup of current state with irrelevant commit message. Everything is described at the end of the work in PR's description and squash merged.
- from-nibly 3y agoBut then you can't use blame to look at the current code state. And it also becomes a nightmare to revert your changes.
- dolni 3y agoGiant PRs that are squashed into one commit are an anti-pattern. Every commit should contain exactly one logical change AND a descriptive commit message. Unfortunately a good chunk of the industry doesn't have the discipline to do this. If you have ever worked in a project where there was discipline around committing, you know there is lots of value in doing so (rebasing becomes easier, you unlock the power of bisect, log is actually useful).
- argulane 3y agoThis! Also doing PR code review is soo much nicer if each commit is logically self contained with a nice commit message.