7 ms·

David from Sentry here. If yall have feedback around Spotlight we’d love to hear it. This is a passion project for a few of us and seemed like a natural fit for

by zeeg 3y ago

David from Sentry here. If yall have feedback around Spotlight we’d love to hear it. This is a passion project for a few of us and seemed like a natural fit for our technology, and becomes especially interesting with the service oriented world we all find ourselves in.

kyawzazaw 3y ago
https://spotlightjs.com/ https://spotlightjs.com/ doesn't work Only http
- zeeg 3y ago
  What error are you seeing? Works over here. Its hosted on Vercel so shouldn’t be too complicated or different than most similar deployments.
  - OJFord 3y ago
    Both say 'Unable to connect' for me (Firefox built in page) in the UK. Which I think means the name resolved but no response. (But I'm on mobile so can't say more than that.)
    - zeeg 3y ago
      Are you using NextDNS by chance? Someone reported an issue with it blocking the domain on there, but it was unclear _which_ setting was blocking it. Was also odd given its just a Vercel website and the domain (afaik) was unused prior.
      - OJFord 3y ago
        Yeah I just came back here to say that was the culprit. It's because it's a newly registered domain.
    - e1g 3y ago
      The domain name is new, and those get blocked by many DNS-based ad-blocks. I use NextDNS and get the same error - spotlightjs.com is blocked (resolves to 0.0.0.0) NextDNS calls this "Block Newly Registered Domains (NRDs)", and applies to all domains <30 days. ZScaler has something similar for corporate users, so people connecting from work might see a big red warning page.
      - simonw 3y ago
        Isn't a tool that blocks all domains registered less than 30 days ago hugely annoying? I guess I can see the upside in terms of helping avoid newly registered phishing sites, but I don't think I could live with the downsides.
        OJFord 3y ago
        It happens I frequently enough that I forgot it, I've used NextDNS for at least a year, and it's happened at most once before. How often do you try (deliberately) to use something so newly registered? Frankly even most new things have older domains. (I know I'm not alone here in having domains registered for projects that may or may not ever materialise..!) Also maybe worth saying that it's not even really about NextDNS as a tool, it's that block list or ones like it. I'm not sure if it's enabled by default or not.
        simonw 3y ago
        "How often do you try (deliberately) to use something so newly registered?" Often when myself or one of my friends launches a new web project!
- arcanemachiner 3y ago
  Works on my machine.
patrick91 3y ago
I'd love to see this a replacement for django debug toolbar in future :D
paulirish 3y ago
I'm curious. I figure you considered building the UI as a DevTools extension; why 'd you go this in-page-DOM-overlay route instead?
- zeeg 3y ago
  More control and far lower barrier to hack on. This actually opens up a lot of doors for us even if you ignore usability and discoverability. For example, we have a POC that pops the overlay when a server error happens, giving you a rich debug experience where otherwise you might not be able to have one.
  - paulirish 3y ago
    I can't disagree at all. And this is super useful, thanks.
amccloud 3y ago
Does this new package impact devtools source and initiators in a way where everything is attributed to spotlight?
- zeeg 3y ago
  What’s an example concern? It shouldn’t anymore than Sentry already does
  - amccloud 3y ago
    Mostly other devs seeing instrument.js everywhere in devtools vs. the actual source. The issue is for all envs and in development has been most problematic. So obscuring console.log or network initiators the way Sentry currently does. Webpack and bundlers seem to generally have this problem too. Sourcemaps help resolve when present in dev.
lol768 3y ago
Hey David! Few questions: I'm slightly stuck with the Vite plugin Currently getting this when trying to do an npm run dev: [plugin externalize-deps] No known conditions for "./vite-plugin" entry in "@spotlightjs/sidecar" package The plugin "externalize-deps" was triggered by this import vite.config.ts:7:29: 7 │ import spotlightSidecar from '@spotlightjs/sidecar/vite-plugin'; Should I be telling externalize-deps to leave it alone somehow? Also, I note the PHP SDK has gotten support for Spotlight - are there plans to do the same for the .NET SDK too?
- deleted 3y ago
  [deleted]
- zeeg 3y ago
  Let me circle back on the Vite issue. Bundles are the biggest challenge when doing this turns out :) Would you mind opening a GitHub so we can circle back there? Regarding .NET - it’s coming to all Sentry SDKs (even mobile!). They were looking at .NET already but I’m not sure off hand what prevented its release. I’d expect our other core languages have full support in the next 60 days.
  - lol768 3y ago
    > Let me circle back on the Vite issue. Bundles are the biggest challenge when doing this turns out :) > > Would you mind opening a GitHub so we can circle back there? For anyone else in this boat, I got it working by adding "type": "module" to my package.json file. Getting Tailwind to play nice with this was a bit of a battle, and I didn't manage to figure out how to import the defaultTheme properly, but Spotlight works flawlessly and the Vite plugin auto-starts the sidecar.
- brungarc 3y ago
  Thanks for asking, created a ticket for .NET support here: https://github.com/getsentry/sentry-dotnet/issues/2955 https://github.com/getsentry/sentry-dotnet/issues/2955 I'm actually looking forward to it, I wanted to try on NuGet Trends but stopped on the first hurdle: https://github.com/dotnet/nuget-trends/pull/247 https://github.com/dotnet/nuget-trends/pull/247

by zeeg 3y ago

kyawzazaw 3y ago

https://spotlightjs.com/ https://spotlightjs.com/ doesn't work Only http

zeeg 3y ago
What error are you seeing? Works over here. Its hosted on Vercel so shouldn’t be too complicated or different than most similar deployments.
- OJFord 3y ago
  Both say 'Unable to connect' for me (Firefox built in page) in the UK. Which I think means the name resolved but no response. (But I'm on mobile so can't say more than that.)
  - zeeg 3y ago
    Are you using NextDNS by chance? Someone reported an issue with it blocking the domain on there, but it was unclear _which_ setting was blocking it. Was also odd given its just a Vercel website and the domain (afaik) was unused prior.
    - OJFord 3y ago
      Yeah I just came back here to say that was the culprit. It's because it's a newly registered domain.
  - e1g 3y ago
    The domain name is new, and those get blocked by many DNS-based ad-blocks. I use NextDNS and get the same error - spotlightjs.com is blocked (resolves to 0.0.0.0) NextDNS calls this "Block Newly Registered Domains (NRDs)", and applies to all domains <30 days. ZScaler has something similar for corporate users, so people connecting from work might see a big red warning page.
    - simonw 3y ago
      Isn't a tool that blocks all domains registered less than 30 days ago hugely annoying? I guess I can see the upside in terms of helping avoid newly registered phishing sites, but I don't think I could live with the downsides.
      - OJFord 3y ago
        It happens I frequently enough that I forgot it, I've used NextDNS for at least a year, and it's happened at most once before. How often do you try (deliberately) to use something so newly registered? Frankly even most new things have older domains. (I know I'm not alone here in having domains registered for projects that may or may not ever materialise..!) Also maybe worth saying that it's not even really about NextDNS as a tool, it's that block list or ones like it. I'm not sure if it's enabled by default or not.
        simonw 3y ago
        "How often do you try (deliberately) to use something so newly registered?" Often when myself or one of my friends launches a new web project!
arcanemachiner 3y ago
Works on my machine.

patrick91 3y ago

I'd love to see this a replacement for django debug toolbar in future :D

paulirish 3y ago

I'm curious. I figure you considered building the UI as a DevTools extension; why 'd you go this in-page-DOM-overlay route instead?

zeeg 3y ago
More control and far lower barrier to hack on. This actually opens up a lot of doors for us even if you ignore usability and discoverability. For example, we have a POC that pops the overlay when a server error happens, giving you a rich debug experience where otherwise you might not be able to have one.
- paulirish 3y ago
  I can't disagree at all. And this is super useful, thanks.

amccloud 3y ago

Does this new package impact devtools source and initiators in a way where everything is attributed to spotlight?

zeeg 3y ago
What’s an example concern? It shouldn’t anymore than Sentry already does
- amccloud 3y ago
  Mostly other devs seeing instrument.js everywhere in devtools vs. the actual source. The issue is for all envs and in development has been most problematic. So obscuring console.log or network initiators the way Sentry currently does. Webpack and bundlers seem to generally have this problem too. Sourcemaps help resolve when present in dev.

lol768 3y ago

Hey David! Few questions: I'm slightly stuck with the Vite plugin Currently getting this when trying to do an npm run dev: [plugin externalize-deps] No known conditions for "./vite-plugin" entry in "@spotlightjs/sidecar" package The plugin "externalize-deps" was triggered by this import vite.config.ts:7:29: 7 │ import spotlightSidecar from '@spotlightjs/sidecar/vite-plugin'; Should I be telling externalize-deps to leave it alone somehow? Also, I note the PHP SDK has gotten support for Spotlight - are there plans to do the same for the .NET SDK too?

deleted 3y ago
[deleted]
zeeg 3y ago
Let me circle back on the Vite issue. Bundles are the biggest challenge when doing this turns out :) Would you mind opening a GitHub so we can circle back there? Regarding .NET - it’s coming to all Sentry SDKs (even mobile!). They were looking at .NET already but I’m not sure off hand what prevented its release. I’d expect our other core languages have full support in the next 60 days.
- lol768 3y ago
  > Let me circle back on the Vite issue. Bundles are the biggest challenge when doing this turns out :) > > Would you mind opening a GitHub so we can circle back there? For anyone else in this boat, I got it working by adding "type": "module" to my package.json file. Getting Tailwind to play nice with this was a bit of a battle, and I didn't manage to figure out how to import the defaultTheme properly, but Spotlight works flawlessly and the Vite plugin auto-starts the sidecar.
brungarc 3y ago
Thanks for asking, created a ticket for .NET support here: https://github.com/getsentry/sentry-dotnet/issues/2955 https://github.com/getsentry/sentry-dotnet/issues/2955 I'm actually looking forward to it, I wanted to try on NuGet Trends but stopped on the first hurdle: https://github.com/dotnet/nuget-trends/pull/247 https://github.com/dotnet/nuget-trends/pull/247