3 ms·
None of those timelines are realistic: * Most CLs don't take multiple days to write * Reasonably-sized CLs take 5-10 minutes to review - if I have things to s
by Arainach 3y ago
None of those timelines are realistic:
* Most CLs don't take multiple days to write
* Reasonably-sized CLs take 5-10 minutes to review - if I have things to say. Much less if the code looks good and I don't have any requests.
* I cannot think of any CL in the last 5 years where I made a comment that caused someone to "rewrite everything from scratch". Most feedback can be done in a few clicks in an IDE which supports refactor or a few minutes of copy/paste.