4 ms·
Your comment is why I highly recommend using conventional comment labels, https://conventionalcomments.org/#labels https://conventionalcomments.org/#labels, whe
by hn_throwaway_99 3y ago
Your comment is why I highly recommend using conventional comment labels, https://conventionalcomments.org/#labels https://conventionalcomments.org/#labels, when doing code reviews.
We've internalized them where I work and I think they're really valuable. When it's abundantly clear whether something is a nitpick, suggestion, or a blocking issue, because it literally has a prefix to that effect, it takes a lot of the potential stress and confrontation out of the code review process, on both sides.
Note you also don't need to memorize the labels, but starting with one forces the reviewer to ask themselves the question "Should I really block the merge for this?"