This (as well as close relatives of this) is still relatively common because we still don't have a great option for to have non-visible text that's screen-reade

This (as well as close relatives of this) is still relatively common because we still don't have a great option for to have non-visible text that's screen-reader accessible in all cases. aria-label and things like that have replaced some usages of this pattern but not all.