2 ms·

A more "correct" fix has been posted https://github.com/openzfs/zfs/pull/15615 https://github.com/openzfs/zfs/pull/15615

• jeffbee 3y ago
  Neither of these fixes are great because neither of them include tests. This is a dataloss bug in a filesystem, no existing test covered it, and no new tests were added to demonstrate the efficacy of the supposed fix or prevent regressions.
  • frankjr 3y ago
    There's an ongoing work on a stress test for this. https://github.com/openzfs/zfs/pull/15608 https://github.com/openzfs/zfs/pull/15608
  • rincebrain 3y ago
    There was, actually, a test, but it turns out to be rather hard to make a deterministic test to reproduce a rare race condition without sticking your fingers in at runtime and forcing the "wrong" ordering.
  • mnd999 3y ago
    The same was true of the fix for the completely deterministic cp from unencrypted to encrypted with block cloning. There doesn’t seem to me much incentive to write tests.