3 ms·
So much. I think most engineers aren't really equipped with the behavioral skills to conduct code review in a healthy way, and I think the industry just turns a
by alex_lav 3y ago
So much. I think most engineers aren't really equipped with the behavioral skills to conduct code review in a healthy way, and I think the industry just turns a blind eye to terrible/unproductive behavior being a core part of the development process. The prevalence of comments starting with "Nit" is a good example. Never leave a nit.
I also think reviewers shouldn't have a freeform textbox to leave comments in. I think feedback items should be something like a dropdown. The goal is to remove opinion and bias as much as possible. Style, linting, etc should all be automated.
- fosterfriends 3y agoI feel you. If you want to hear my write-up against nits... https://graphite.dev/blog/what-are-nits https://graphite.dev/blog/what-are-nits > When folks defend nits, I suspect they are actually defending “non-blocking” comments - including educational remarks, context sharing, suggestions, aspirations, and more. Poor definitions from Google’s otherwise excellent style guide muddles two orthogonal ideas: non-blocking comments, and trivial preference-based requests. The former is a healthy means of communication between engineers writing code. The latter is an inconsistent inefficiency.