15 ms·
Wonder how good your "fix" is when we have: a() + !b Also wonder what are your plans for the future? What will you do if Crockford refuses to accept
by voidr 14y ago
Wonder how good your "fix" is when we have:
a() +
!b
Also wonder what are your plans for the future? What will you do if Crockford refuses to accept your pull request because it is a) pointless b) encourages bad coding habits? Will you maintain your forked version and tell everyone that your version is better?
- beaumartinez 14y ago> Will you maintain your forked version? Worst comes to worst, you can always rebase newer commits from the original Bootstrap repo locally.
- deleted 14y ago[deleted]
- masklinn 14y ago> That idiom is useful to no one. And yet > Minification of Javascript should never result in a behavior change. You're flying in the face of your own holier than you declarations here.
- dalke 14y ago"Minification of Javascript should never result in a behavior change." Hahahaha. Like that one change was the only behavior change that JSMin did to arbitrary Javascript. Read the JSMin documentation. It specifically says that it changes 'a + ++b' to 'a+++b', which is the same as 'a++ + b'. This is another behavior change in JSMin. Is the forker going to fix all of the behavior changes that JSMin does to Javascript which is valid but does not pass the JSLint test? Or only brag about fixing the one problem de jour?