4 ms·
It was eventually fixed in another PR, despite the maintainer's lengthy ranting. https://github.com/opencart/opencart/pull/12951#issuecomment-1819582555 https:
by richbell 3y ago
It was eventually fixed in another PR, despite the maintainer's lengthy ranting.
https://github.com/opencart/opencart/pull/12951#issuecomment-1819582555 https://github.com/opencart/opencart/pull/12951#issuecomment...
- tommy_axle 3y agoThanks, I didn't realize. The only thing with PR 12951 is that one of the invalid replacements covered on the other PR was missed (https://github.com/mhcwebdesign/opencart/blob/bc60f21aa2ece0ebfa66800e02ebe06910464953/upload/admin/controller/common/security.php#L285 https://github.com/mhcwebdesign/opencart/blob/bc60f21aa2ece0...). Normally I'd just report it to the project but given the behavior and language observed surrounding this, why even bother.