4 ms·

So far nobody has proven that this bug exists on FreeBSD, though. :)

by keep_reading 3y ago

Always_Anon 3y ago
Because FreeBSD is behind Linux in copying with reflinks. They couldn't even reproduce the issue if they wanted to.
- ryao 3y ago
  This code was implemented for FreeBSD before it was implemented for Linux. I do not think it has made it to a FreeBSD release yet though.
  - Always_Anon 3y ago
    No it wasn't: https://github.com/openzfs/zfs/issues/405 https://github.com/openzfs/zfs/issues/405 This hit Linux first, which is why Linux experienced the issue. FreeBSD does not currently have reflink cp.
  - mnd999 3y ago
    It’s in FreeBSD 14. But they disabled block cloning by default.
    - deleted 3y ago
      [deleted]
ryao 3y ago
The bugs are in cross platform code beneath the VFS. They exist on FreeBSD too.
frankjr 3y ago
https://github.com/openzfs/zfs/issues/15526#issuecomment-1823682717 https://github.com/openzfs/zfs/issues/15526#issuecomment-182...
- keep_reading 3y ago
  Looks like a deeper bug has been exposed due to the way bclone works? They're finding issues now on ZFS versions predating bclone Edit: yep, it's an older bug. Set zfs_dmu_offset_next_sync=0 to save your data https://github.com/openzfs/zfs/issues/15526#issuecomment-1823760920 https://github.com/openzfs/zfs/issues/15526#issuecomment-182...
  - frankjr 3y ago
    Not sure what's your point. The comment I linked to just confirmed that the bug (whichever it might be) has reproduced on FreeBSD.
    - keep_reading 3y ago
      Just following up for the readers of the thread
  - fortani 3y ago
    Nope, somebody managed to reproduce this issue even with zfs_dmu_offset_next_sync=0 https://github.com/openzfs/zfs/issues/15526#issuecomment-1826065538 https://github.com/openzfs/zfs/issues/15526#issuecomment-182...
    - keep_reading 3y ago
      Apply this patch, it appears to be the real fix. https://github.com/openzfs/zfs/pull/15571/files?diff=split&w=0 https://github.com/openzfs/zfs/pull/15571/files?diff=split&w...

So far nobody has proven that this bug exists on FreeBSD, though. :)

Always_Anon 3y ago

Because FreeBSD is behind Linux in copying with reflinks. They couldn't even reproduce the issue if they wanted to.

ryao 3y ago
This code was implemented for FreeBSD before it was implemented for Linux. I do not think it has made it to a FreeBSD release yet though.
- Always_Anon 3y ago
  No it wasn't: https://github.com/openzfs/zfs/issues/405 https://github.com/openzfs/zfs/issues/405 This hit Linux first, which is why Linux experienced the issue. FreeBSD does not currently have reflink cp.
- mnd999 3y ago
  It’s in FreeBSD 14. But they disabled block cloning by default.
  - deleted 3y ago
    [deleted]

ryao 3y ago

The bugs are in cross platform code beneath the VFS. They exist on FreeBSD too.

frankjr 3y ago

https://github.com/openzfs/zfs/issues/15526#issuecomment-1823682717 https://github.com/openzfs/zfs/issues/15526#issuecomment-182...

keep_reading 3y ago
Looks like a deeper bug has been exposed due to the way bclone works? They're finding issues now on ZFS versions predating bclone Edit: yep, it's an older bug. Set zfs_dmu_offset_next_sync=0 to save your data https://github.com/openzfs/zfs/issues/15526#issuecomment-1823760920 https://github.com/openzfs/zfs/issues/15526#issuecomment-182...
- frankjr 3y ago
  Not sure what's your point. The comment I linked to just confirmed that the bug (whichever it might be) has reproduced on FreeBSD.
  - keep_reading 3y ago
    Just following up for the readers of the thread
- fortani 3y ago
  Nope, somebody managed to reproduce this issue even with zfs_dmu_offset_next_sync=0 https://github.com/openzfs/zfs/issues/15526#issuecomment-1826065538 https://github.com/openzfs/zfs/issues/15526#issuecomment-182...
  - keep_reading 3y ago
    Apply this patch, it appears to be the real fix. https://github.com/openzfs/zfs/pull/15571/files?diff=split&w=0 https://github.com/openzfs/zfs/pull/15571/files?diff=split&w...