3 ms·

Clever code is probably the worst code you could write

• deleted 3y ago
  [deleted]
• trealira 3y ago
  > “While I understand how complex this was, when it comes to performance reviews, this code looks trivial. It looks too easy, too simple. > I would recommend writing an implementation doc of this module just so we can demonstrate that this was actually quite complex.” This sounds strangely bureaucratic. But I guess it's good that your manager would give you tips on making yourself look better; it's better than just not knowing that you're expected to write these docs whenever your code looks like it was too easy to write, and then others aren't as impressed with your work. Also, I now wish I could see the diffs between the before and after versions of the data enrichment module, from the two-file spaghetti monster that seemed to work to the neat, unit tested version, just because it seems like something one could learn from. Obviously, it's proprietary code owned by the author's employer, by whom they were paid to write this code and not share it, so I understand why they wouldn't share it.