4 ms·
A bit more context wouldn't hurt. You don't want attendees, who don't know any better, to adopt really bad practices. For example, what if this was the context
by latch 15y ago
A bit more context wouldn't hurt.
You don't want attendees, who don't know any better, to adopt really bad practices. For example, what if this was the context:
sql = "select * from users where id = #{params[:id]}"
Although even here there's a right and a wrong way to approach this.
- burke 15y agoThis is pretty important context. I probably would have called the presenter out too.
- mtsmith85 15y agoHmm. I believe that that was just an example, not the actual context.
- latch 15y agoyes, it was just an example.
- sunkencity 15y agohttp://phillyrb.org/events/115 http://phillyrb.org/events/115 SQL injection seems pretty far from the metaprogramming context, if that was the actual event.
- Delmania 15y agoYour last sentence is key here. I personally think you need to ask yourself when you have the urge to call someone out "does this add value to the current discussion?". If it does, you should lead in with questions like "Have you thought about..?" or "I don't think your example is quite correct, here's why.." Definitely stating "You're wrong, this is how you should do it" is great way to immediately shut the other person down. If calling out the person in question doesn't add value to the conversation, save it for a private conversation later. Simply being technically adept is no excuse for poor communication skills.