3 ms·
hard to say without seeing the pull requests, but if you edit compiled code and call it a typo you're probably at risk of doing a lot of things wrong. True - w
by yummyfajitas 15y ago
hard to say without seeing the pull requests, but if you edit compiled code and call it a typo you're probably at risk of doing a lot of things wrong.
True - what you should do is submit a fix that takes compiled code out of the repo and replaces it with a build script.
- technoweenie 15y agoThat's definitely a change I'd bring up with the project first. I agree that having compiled code in there is bad, but it's typically not something a first time pull requester touches. Same goes for project files (Gemfiles, package.json, licenses, changelogs, whatever).