4 ms·

With some pull requests, I've encountered the "probably should have emailed the list" and the "here's the style guide" in a single pull request. As a maintaine

by chops 15y ago

With some pull requests, I've encountered the "probably should have emailed the list" and the "here's the style guide" in a single pull request. As a maintainer, however, I'm far more lenient in these things. If someone takes the time to fix a bug or add a neat new feature in something I maintain, I'm greatful for it, and I'm not going to get anal about the pull request. If there's something about it I find needs changing, I'll accept the pull request and fix it myself (with a few exceptions), and inform the contributor of the changes I've made, why I made them. I'd rather not make pull requests be an exercise in frustration for the contributor[1]. Usually, you want more people to help with your project, and frustrating your contributors isn't a good way to encourage that. [1] I say this as someone who, with one pull request, spent several hours over a few days trying to get a 15-line change accepted (about 10 of which were comment lines), with lots of debate over the most of the requested changes being anal things like "add a space after the comma, remove a space after the =". I was damn near the end of my rope and ready to just say "fuck it, if you don't want my fix, don't take it, I'll just maintain my own fork."

NeutronBoy 15y ago
Thanks for being an awesome maintainer! I made my first contribution to a GH project a couple of weeks ago. It was only a few lines, and the maintainer had to make a few modifications before he merged it, but I got some really positive feedback from him and you could tell how grateful they were.
jeremysalwen 15y ago
You think that's bad, I had a 19 email back and forth with a developer over a patch I created to add three standard libraries to the linker options. He did not disagree with me that according to the specification, he was using functions which required linking to the aforementioned libraries. He did not dispute that adding these libraries if they were not strictly necessary would cause no disruption in the cases where it already built. He simply kept saying "well, it works for me and other people," and refused to compile simple test programs on his machine to see why my computer and the spec differed from his computer. Months later, he silently incorporates the change...Talk about annoying..
X-Istence 15y ago
I've submitted pull requests to projects on Github and while there has sometimes been discussion, so far my changes have been pulled into the main project without issues. Most of my commits are to homebrew for software I'd like in in brew but that isn't there, and also modifications to current software that is there to get it to compile on newer versions of Mac OS X.

by chops 15y ago

NeutronBoy 15y ago

Thanks for being an awesome maintainer! I made my first contribution to a GH project a couple of weeks ago. It was only a few lines, and the maintainer had to make a few modifications before he merged it, but I got some really positive feedback from him and you could tell how grateful they were.

jeremysalwen 15y ago

You think that's bad, I had a 19 email back and forth with a developer over a patch I created to add three standard libraries to the linker options. He did not disagree with me that according to the specification, he was using functions which required linking to the aforementioned libraries. He did not dispute that adding these libraries if they were not strictly necessary would cause no disruption in the cases where it already built. He simply kept saying "well, it works for me and other people," and refused to compile simple test programs on his machine to see why my computer and the spec differed from his computer. Months later, he silently incorporates the change...Talk about annoying..

X-Istence 15y ago

I've submitted pull requests to projects on Github and while there has sometimes been discussion, so far my changes have been pulled into the main project without issues. Most of my commits are to homebrew for software I'd like in in brew but that isn't there, and also modifications to current software that is there to get it to compile on newer versions of Mac OS X.