2 ms·

Well, at least these three: > Did you format the code? > Did the tests pass? > Did you fix the tests? Or did you just comment them out? should be obvious fr

• WirelessGigabit 3y ago
  Absolutely. But we've had developers who, even with extensive coaching, eventually ended up proposing PRs with the issues above. Equally, we had reviewers, who, with extensive coaching, (and I see this a lot with contractor teams), allow PRs like this. I work at a company where I have to speak up. It is ingrained in the way we work. However, with contractor teams that way of working does not always translate well. They don't necessarily 'dare' to speak up on PRs of their own colleagues. It's a weird dynamic.