4 ms·
If you are in charge of the review process, simply start closing their PRs, list the reasons why, or better yet create a document you can reference establishing
by soulofmischief 3y ago
If you are in charge of the review process, simply start closing their PRs, list the reasons why, or better yet create a document you can reference establishing your guidelines. Don't back and forth; if they can't meet a simple set of guidelines, the PR is not ready for review.
Let their manager take issue with it. Fight it, bring it to their manager's manager, whatever. A company like that is not worth working for, so try to make it a company that is, or leave, but do yourself a favor and find a team you love.
- ra0x3 3y ago> better yet create a document you can reference establishing your guidelines. This. Remove as much ambiguity and grey area as possible.
- 9659 3y ago> better yet create a document you can reference establishing your guidelines. How about working on a document that establishes the companies guidelines? I can not imagine having to meet everyone's personal quality bar.
- soulofmischief 3y agoYou don't have to meet everyone's personal quality bar, just the person who is in charge of reviewing your code. Write good code and you won't have a problem!
- icedchai 3y agoMy expectations here were a bit lower, given the individual involved: write code that actually runs.
- soulofmischief 3y agoHa! I think you might be asking for too much these days!