4 ms·
Sounds like something to raise with their manager. Or with this person, before even reading the PR, "Hey - just to check before I review this, does it work on y
by josephg 3y ago
Sounds like something to raise with their manager. Or with this person, before even reading the PR, "Hey - just to check before I review this, does it work on your machine? Have you tested it?". If they say no, close the PR and tell them to do that before opening it. If they lie, call them on it. If they aren't learning, don't waste your time hiding this useless coworker's failures.
- icedchai 3y agoI have raised it in the past and will do so again. One of the problems is the manager has no software engineering experience and his view of "working norms" often go against mine. Some of my complaints are fairly basic: test/review your own work before asking someone else to review it. This should be applicable regardless of industry.
- nathants 3y agotime to go next?
- icedchai 3y agoI've been thinking about that for a while, for a variety of reasons. This is one of the smaller ones. Probably after the holidays.
- josephg 3y agoIt is applicable regardless of industry. If your manager isn’t technical, drag the nearest senior engineer into the conversation too. As for the PR, don’t bother. “Hey this code you’ve submitted for code review doesn’t even compile. I’m your colleague, not a human compiler. Please don’t waste my time with this again” -> Close issue.