3 ms·

Isn't the primary and possibly only objection to GitHub PRs just that they don't allow individual commit commenting?

by XorNot 3y ago

mdaniel 3y ago
GH for sure allows commentary on individual commits (e.g. <https://github.com/torvalds/linux/commit/23816724fdbd47c28bc998866fd7bc5ad9f0e535#all_commit_comments https://github.com/torvalds/linux/commit/23816724fdbd47c28bc...>) but they do not automatically roll up to the top-level PR view (since, how would that work with cherry-picks: it shows up in every PR? what if, as is more likely, the line were superseded in a subsequent commit?)
- seba_dos1 3y ago
  How are cherry-picks relevant? Cherry-picking creates completely separate and topologically unrelated commits. GitLab handles comments on commits within MRs pretty well. It still doesn't make it adequate for projects like Linux though.
CuriousCosmic 3y ago
Github PRs do not make it easy for you to sign merge commits. It's possible in gitlab to my knowledge but in github it's a pain in the ass. And github needlessly touches PR commits so that even if you could fast-forward merge/rebase the PR while keeping signatures in tact, github will still regenerate your commits, breaking the hashes and signatures.
aseipp 3y ago
No, it's not enough. One of the most important features missing is that kernel developers will want the equivalent of `git range-diff` (i.e. the ability to compare two versions of a single commit which was submitted as part of a batch of commits) in the UX for code review purposes. The lack of this feature makes the entire thing a non-starter, both Github and Gitlab. That said, they have accepted some PRs on GitHub at the past at one point as an experiment IIRC. But no, the current features they want are not there. The only real practical alternative is probably something like Gerrit, which still probably is missing features they want, or to write their own patch review tool on top of lore.lkml.org and some other infra.
seba_dos1 3y ago
GitHub's UI is inadequate for some workflows in much smaller projects already, for many different reasons.

Isn't the primary and possibly only objection to GitHub PRs just that they don't allow individual commit commenting?

by XorNot 3y ago

Isn't the primary and possibly only objection to GitHub PRs just that they don't allow individual commit commenting?

GH for sure allows commentary on individual commits (e.g. <https://github.com/torvalds/linux/commit/23816724fdbd47c28bc998866fd7bc5ad9f0e535#all_commit_comments https://github.com/torvalds/linux/commit/23816724fdbd47c28bc...>) but they do not automatically roll up to the top-level PR view (since, how would that work with cherry-picks: it shows up in every PR? what if, as is more likely, the line were superseded in a subsequent commit?)

seba_dos1 3y ago
How are cherry-picks relevant? Cherry-picking creates completely separate and topologically unrelated commits. GitLab handles comments on commits within MRs pretty well. It still doesn't make it adequate for projects like Linux though.

CuriousCosmic 3y ago

Github PRs do not make it easy for you to sign merge commits. It's possible in gitlab to my knowledge but in github it's a pain in the ass. And github needlessly touches PR commits so that even if you could fast-forward merge/rebase the PR while keeping signatures in tact, github will still regenerate your commits, breaking the hashes and signatures.

aseipp 3y ago

No, it's not enough. One of the most important features missing is that kernel developers will want the equivalent of `git range-diff` (i.e. the ability to compare two versions of a single commit which was submitted as part of a batch of commits) in the UX for code review purposes. The lack of this feature makes the entire thing a non-starter, both Github and Gitlab. That said, they have accepted some PRs on GitHub at the past at one point as an experiment IIRC. But no, the current features they want are not there. The only real practical alternative is probably something like Gerrit, which still probably is missing features they want, or to write their own patch review tool on top of lore.lkml.org and some other infra.

seba_dos1 3y ago

GitHub's UI is inadequate for some workflows in much smaller projects already, for many different reasons.