3 ms·

I second this. As a maintainer, I have a very good understanding of how long it would take (someone familiar with the codebase) to make certain changes. It's f

I second this. As a maintainer, I have a very good understanding of how long it would take (someone familiar with the codebase) to make certain changes. It's far from disrespectful to push before merging when the alternative is to waste both the contributor's time and my own on at least 1 round of purely code style feedback. As a drive-by contributor, I always leave the box checked—the parent commenter seems to be unaware that GitHub gives you this option—in case I wasn't able to match the project's code style, or there's some other reason for the maintainer(s) to make minor changes. Keep in mind that the maintainers could always just squash and clean up afterwards if you were to uncheck it. The idea of maintainers doing what they want to your changeset is really inseparable from PRs as a concept; while I'm in favour of teaching/knowledge-sharing via code reviews, it's not expected and certainly not owed. (Tangentially, I'm finding that with Nix it's now feasible to apply fixes and customisations to packages even if they have "hostile maintainers".)

tommiegannert 3y ago
You mean PR edits? Yes, for small touchups, certainly. Anything that makes the life of maintainers easier. I'm talking about changes that requires maintainers to check out code. You shouldn't feel you have to do that, and if there are many PRs, you shouldn't feel you have the time to do so. > Tangentially, I'm finding that with Nix it's now feasible to apply fixes and customisations to packages even if they have "hostile maintainers" I have that same feeling with Docker/K8S. I don't know how many images I've modified to make them runnable as non-root, but quite a few.
zzzeek 3y ago
> As a drive-by contributor, I always leave the box checked—the parent commenter seems to be unaware that GitHub gives you this option I have no idea what this is. Can you share specifics?
- YoshiRulz 3y ago
  When you open a PR, look for the "Allow edits by maintainers" checkbox beside the "Create pull request" button. For PRs you've made earlier, you can find it in the sidebar under the participants list. [1]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork https://docs.github.com/en/pull-requests/collaborating-with-...
  - zzzeek 3y ago
    oh that thing. I've always found the flow for "editiable PRs" in github to be horrendously confusing and difficult to use. we do all of our edits in Gerrit. I was hoping you meant a checkbox that says, "this contributor is OK with the maintainers taking over this PR to finish it up"

tommiegannert 3y ago

You mean PR edits? Yes, for small touchups, certainly. Anything that makes the life of maintainers easier. I'm talking about changes that requires maintainers to check out code. You shouldn't feel you have to do that, and if there are many PRs, you shouldn't feel you have the time to do so. > Tangentially, I'm finding that with Nix it's now feasible to apply fixes and customisations to packages even if they have "hostile maintainers" I have that same feeling with Docker/K8S. I don't know how many images I've modified to make them runnable as non-root, but quite a few.

zzzeek 3y ago

> As a drive-by contributor, I always leave the box checked—the parent commenter seems to be unaware that GitHub gives you this option I have no idea what this is. Can you share specifics?

YoshiRulz 3y ago
When you open a PR, look for the "Allow edits by maintainers" checkbox beside the "Create pull request" button. For PRs you've made earlier, you can find it in the sidebar under the participants list. [1]: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork https://docs.github.com/en/pull-requests/collaborating-with-...
- zzzeek 3y ago
  oh that thing. I've always found the flow for "editiable PRs" in github to be horrendously confusing and difficult to use. we do all of our edits in Gerrit. I was hoping you meant a checkbox that says, "this contributor is OK with the maintainers taking over this PR to finish it up"