5 ms·
Sure, but then there's nothing wrong with rebasing it and making a nicer story for other people that want to review it. Diffs are great but sometimes they're j
by nkozyra 3y ago
Sure, but then there's nothing wrong with rebasing it and making a nicer story for other people that want to review it.
Diffs are great but sometimes they're just as overwhelming in a huge PR. It's nice to first follow 5-10 commits in chunks of logical change.
- dilyevsky 3y agoDont send huge prs. They are hard/impossible to review anyway with good commit history or not
- arein3 3y agoI don't know why people are obsessed with squash merging. I always rebase (when needed) to preserve commit history. It's a good best practice, and makes it easier to spot errors after fixing conflicts. I suspect squashers use the wrong tools. Use source tree, or, if you are on linux, smartgit. You can see a detailed log, which makes it much easier.