3 ms·
I don't strictly wait for CI to pass before reviewing, but I don't think it's a crazy idea. There's no point in taking the time to understand a set of changes a
by plorkyeran 3y ago
I don't strictly wait for CI to pass before reviewing, but I don't think it's a crazy idea. There's no point in taking the time to understand a set of changes and evaluate the design and such if it doesn't actually work in the first place and needs to be reworked.
If you have something that's easy to test locally and the CI checks are just a backstop then the initial PR should nearly always pass, but if your CI checks are much more thorough than a developer can do manually then a PR initially being in a broken state may be a routine occurrence.