8 ms·
Not all containers right? Just unordered containers. It’s a bit weird of a strategy though - most other applications use a random seed for unordered hash tables
by vlovich123 3y ago
Not all containers right? Just unordered containers. It’s a bit weird of a strategy though - most other applications use a random seed for unordered hash tables.
- wyldfire 3y agoRather than change the implementation of the DenseMap/DenseSet/StringMap/StringSet containers to mask such codegen defects, the community opted to create a test strategy to find the defects instead. I would guess that this may also end up favoring the execution performance of the compiler over other design choices, but I could be wrong about that one.
- JonChesterfield 3y agoA random seed for unordered hash tables would make a mess of reproducibility. Bad thing in this context.
- vlovich123 3y agoThe iteration order is undefined for these containers. The whole point of the reverse iteration is to find when reproducibility is dependent on undefined iteration order. If the reverse iteration accomplishes this, so would a random seed.