3 ms·
Instead, they run over a merge commit from the base branch. This means CI is always running over commits that don't exist anywhere in the repo, and change when
by filipesilva 3y ago
Instead, they run over a merge commit from the base branch.
This means CI is always running over commits that don't exist anywhere in the repo, and change whenever master changes.
If you re-run GHA after master changes, CI is testing over different code.
Posting because every senior developer that I know is surprised to learn this.
- rurban 3y agoStill wrong title. Do a Tell HN: and use the original title. with your comments
- filipesilva 3y agoSo the submission should be: Title: Tell HN: GitHub Actions on PR don't run over your commit by default URL: empty Text: link plus the comment I had is this right?
- rurban 3y agoNot right, but better. If you link directly, the name must be the title of the url
- filipesilva 3y agoThanks for the guidance! Re-submitted as https://news.ycombinator.com/item?id=37941896 https://news.ycombinator.com/item?id=37941896