3 ms·
Where is "why" in this repetitive review? Also, what is the values of bluntly repeating in a more aggressive style vs bluntly saying the same thing once in a mo
by eviks 3y ago
Where is "why" in this repetitive review? Also, what is the values of bluntly repeating in a more aggressive style vs bluntly saying the same thing once in a more professional manner while also explaining the reason (lack of details)
> First off, the simple stuff: the commit messages are worthless. Having
check seal for mmap(2)
as the commit message is not even remotely acceptable, to pick one
random example from the series (7/8).
- dbsmith83 3y agoTry reading the rest of the review and you will see multiple explanations for why things are not a good idea. I don't even think your cherry picked example is that repetitive. It sounds like a normal conversation to me.
- eviks 3y agoI've read the rest of the review, but "cherry picking" another example wouldn't help when you ignore the issues of the first one and have to add qualifiers (yeah, it's not "that repetitive", it's just repetitive)