3 ms·
> the company doing the proposal here is Google. They [...] should have come in with a more-better-finished product. rm "probably" The PR submitter represent
by heresie-dabord 3y ago
> the company doing the proposal here is Google. They [...] should have come in with a more-better-finished product.
rm "probably"
The PR submitter represents a software giant, love 'em or hate 'em.
It is an understatement to say that the Linux kernel is an important, global-scale software project. A small number of busy people maintain the kernel's design. This is one project where crap should not be submitted.
Whether or not we like the company, a software giant like Google should a) understand the scale of the project and the importance of software design, and b) manifestly understand the rudiments of code quality.
- taeric 3y agoThe part that I think many people have a hard time internalizing, is that this is almost certainly following Google internal "best practices" for how the code is organized and delivered. They famously have "code reviewers" that are there to make sure the code reads well. You can see it in the translations of having 3 flags for the same data. Somewhere, the distinction was made between what the user is asking for, and what the system works with. It is considered a good thing to have that level of abstraction in many large companies. Heck, many small companies go for that.