3 ms·

Surely the changes to panic on conflicting routes being discussed upstream already prove they're willing to flex on that guarantee?

• barsonme 3y ago
  That’s not a breaking change.
  • Macha 3y ago
    How is "this api usage was allowed before and now panics" not a breaking change?
    • avianlyric 3y ago
      Which specific API usage was allowed before and now panics? As far as I can see the only historically allowable API usage that would now panic, is registering exactly the same path twice, which in my books is just a bug. Certainly it's technically a breaking change, but there's huge difference between making all existing usage of the mux interface incompatible with the new changes, and only making obviously incorrect and buggy usages of the interface incompatible.
      • d-z-m 3y ago
        > As far as I can see the only historically allowable API usage that would now panic, is registering exactly the same path twice. This has always resulted in a panic[0]. [0]: https://cs.opensource.google/go/go/+/refs/tags/go1.19:src/net/http/server.go;l=2503 https://cs.opensource.google/go/go/+/refs/tags/go1.19:src/ne...