3 ms·

I wrote my company's git wrapper. It was meant to standardize our workflow and to be communal memory for every lesson learned and sharpened edge shaved. It's

I wrote my company's git wrapper. It was meant to standardize our workflow and to be communal memory for every lesson learned and sharpened edge shaved. It's now 6000 lines of bash. (Ok, I'm a little proud of it. I'll open source it as soon as I rewrite it in Python.)

CSSer 3y ago
What’s the shellcheck output look like? Sounds marvelous.
- jonmayer 3y ago
  Shellcheck clean. But I still want to port it to python.
Buttons840 3y ago
Is it easier to learn the simple concepts of git and have transferable knowledge, or to learn your proprietary 6000 line bash script?
- jonmayer 3y ago
  It's easier to support a company of users when everybody is using the vcs tool in a consistent way.
  - Buttons840 3y ago
    I suppose. I'm bitter because I worked at a company where they wanted git used a certain way, which is fine, manage the main repo however you want. The main repo should have some standards and I will follow them. (Preferably this will be automated to for consistency and to keep egos out of the process.) However, they overstepped and gave me a hard time when they learned I was managing my own local repo how I wanted. I'm relatively good with git and would clean up my pull requests to meet the standards before submitting them to the main repo, but they still hassled me over the naming of my local branches and doing local rebases, etc.
    - jonmayer 3y ago
      That seems unnecessary. Maybe you made someone feel threatened.
thegrim33 3y ago
How do you reconcile this with the fact that the vast majority of git users, both at small and large scales, do not need to do this? Now you have a massive, proprietary to your company, system for committing code that every person that joins the company has to learn and maintain.
- jonmayer 3y ago
  That's a good question. My wrapper isn't meant to insulate the users from git, it's meant to teach git. It shows every git command it runs and gives the user an easier on-ramp.
fouc 3y ago
> I'll open source it as soon as I rewrite it in Python. Realistically speaking, will that happen? Why not throw up the bash code as a separate repository from the python one anyways? As an example. Could throw it into archived mode right after or something perhaps.
- jonmayer 3y ago
  It will happen, but if you want to see the bash, warts and all, here you go. https://github.com/enfabrica/enkit/blob/master/scripts/gee https://github.com/enfabrica/enkit/blob/master/scripts/gee One of the big issues you'll find is that some off the defaults are very specific to my company. I'll fix that in the rewrite.

CSSer 3y ago

What’s the shellcheck output look like? Sounds marvelous.

jonmayer 3y ago
Shellcheck clean. But I still want to port it to python.

Buttons840 3y ago

Is it easier to learn the simple concepts of git and have transferable knowledge, or to learn your proprietary 6000 line bash script?

jonmayer 3y ago
It's easier to support a company of users when everybody is using the vcs tool in a consistent way.
- Buttons840 3y ago
  I suppose. I'm bitter because I worked at a company where they wanted git used a certain way, which is fine, manage the main repo however you want. The main repo should have some standards and I will follow them. (Preferably this will be automated to for consistency and to keep egos out of the process.) However, they overstepped and gave me a hard time when they learned I was managing my own local repo how I wanted. I'm relatively good with git and would clean up my pull requests to meet the standards before submitting them to the main repo, but they still hassled me over the naming of my local branches and doing local rebases, etc.
  - jonmayer 3y ago
    That seems unnecessary. Maybe you made someone feel threatened.

thegrim33 3y ago

How do you reconcile this with the fact that the vast majority of git users, both at small and large scales, do not need to do this? Now you have a massive, proprietary to your company, system for committing code that every person that joins the company has to learn and maintain.

jonmayer 3y ago
That's a good question. My wrapper isn't meant to insulate the users from git, it's meant to teach git. It shows every git command it runs and gives the user an easier on-ramp.

fouc 3y ago

> I'll open source it as soon as I rewrite it in Python. Realistically speaking, will that happen? Why not throw up the bash code as a separate repository from the python one anyways? As an example. Could throw it into archived mode right after or something perhaps.

jonmayer 3y ago
It will happen, but if you want to see the bash, warts and all, here you go. https://github.com/enfabrica/enkit/blob/master/scripts/gee https://github.com/enfabrica/enkit/blob/master/scripts/gee One of the big issues you'll find is that some off the defaults are very specific to my company. I'll fix that in the rewrite.