3 ms·
This can go either way, and it's ultimately a social problem, not a technical one. I find that I fairly often notice some minor issues, like a typo in a commen
by atq2119 3y ago
This can go either way, and it's ultimately a social problem, not a technical one.
I find that I fairly often notice some minor issues, like a typo in a comment. I do want the submitter to fix those, but making them go through a full review cycles is an unfortunate waste of time as I usually trust them to be adult enough to just make the fix and submit.
So I find myself wanting to say "Approve modulo these minor issues". If a project wants to allow this, it needs to either not require approvals, or allow approvals to remain even after changes to a PR.