5 ms·
Surprised he didn't refer to stack PR based systems like Gerrit for reference. I have never tried those apps that build a top GitHub. I remember Facebook's sap
by setheron 3y ago
Surprised he didn't refer to stack PR based systems like Gerrit for reference.
I have never tried those apps that build a top GitHub. I remember Facebook's sapling has a web client as well that does stack reviews.
- eyelidlessness 3y agoThere are two mentions of Gerrit in the article. Granted neither goes into detail, but both reference it as prior art on the topic.
- setheron 3y agoOops. I must have missed the mentions.
- adm_ 3y agoI believe sapling uses https://github.com/ezyang/ghstack https://github.com/ezyang/ghstack under the hood for stacked PR.
- bittermandel 3y agoDoesn't he do just that? > They're already a well-explored user experience problem in existing products like Gerrit and Phabricator.
- jacobegold 3y agoI used to work at FB, and unfortunately the Sapling review client that shows GH PRs has nothing on the the actual internal code review tooling at Facebook (now called Diffs, formerly Phabricator). I miss that tool so much