4 ms·
Are people accepting pull requests without actually reviewing the code being contributed?? That seems like the larger problem...
by JohnFen 3y ago
Are people accepting pull requests without actually reviewing the code being contributed??
That seems like the larger problem...
- sdflhasjd 3y agoThere are projects that automatically merge dependabot PRs...
- mistrial9 3y agoprojects with underpaid and outsourced contractors by any chance?
- MiguelX413 3y agoMore likely, simply open-source projects.
- earthling8118 3y agoFunnily enough I'd assume that those projects would be immune to this type of attack unless the automation is absolutely terrible.
- oalders 3y agoPresumably an automated merge would be checking something like > if: github.event.pull_request.user.login == 'dependabot[bot]'
- turboponyy 3y agoNo, the automated workflow would be something like this: - Run dependabot workflow (outputs: $pr_number) - Automerge $pr_number
- Karellen 3y agoIf dependabot is part of GitHub's own infrastructure, and the last 100 pull requests it sent were good, some maintainers might think it trustworthy. I'm pretty sure there are maintainers of Linux that Linus has been working with for long enough that he trusts them to the point that doesn't feel the need to examine every one of their commits. Also, he can't check every commit closely. Linux 6.5 merged 13,561 commits over 9 weeks[0], which is in excess of 200 commits per day - and that was a small release. Learning to trust regular contributors is one of the things that makes OSS work as scale. Edit: Of course, Linus makes sure that stuff he merges from trusted contributors is actually from them, either because it's from a repo he knows they control, or it's GPG-signed and the signatures are checked. The problem is failing to confirm that commits come from the trusted source you think they're from, not failing to examine the commits themselves. [0] https://lwn.net/Articles/941675/ https://lwn.net/Articles/941675/
- EGreg 3y agoThere should be an actual green checkmark for Dependabot and others
- funcDropShadow 3y agoDependabot should sign it's PRs with a gpg signature. And web interface could get support to check those signatures. That is way more trustworthy than a random green flag in some web ui that changes all the time.
- deathanatos 3y agoIt seems like these are being pushed directly, using stolen credentials. (I.e., attackers are just leaking more credentials & compromising the repo. They're just hiding behind dependabot's good name by spoofing it.)