3 ms·
On the other hand this can lead to getting stuck in a never ending code-review ping-pong game. Having seen both sides of that table many times, you can see the
by Too 3y ago
On the other hand this can lead to getting stuck in a never ending code-review ping-pong game.
Having seen both sides of that table many times, you can see the value in someone who just gets the shit done. Especially since this was security related and may have had some urgency to get merged before a release. Imagining how much work these guys must have accepting patches you can sympathize with taking some shortcuts.
- Arnavion 3y agoNobody's saying the maintainer should have to do a never-ending code review ping pong game. The maintainer is free to come up with their version and expedite committing it. The point is that if their patch is based on the original author's patch (which in this case it is; they just shuffled a few lines around), then the original author should've been credited as Author or Co-Authored-By.