3 ms·
> Why is the fix by the author inferior? The maintainer deemed it inferior and they are the one to decide. By posting on a security list, the maintainer went o
by arghwhat 3y ago
> Why is the fix by the author inferior?
The maintainer deemed it inferior and they are the one to decide. By posting on a security list, the maintainer went out of their way to give the issue critical priority, speedy processing and extra critical correctness review. We all like the feeling of credit, but this context is very important.
It's too bad the proposed fix wasn't good enough, but getting the issue resolved is always first priority, above getting claim to the fix.
- lr1970 3y ago> We all like the feeling of credit, but this context is very important. Exactly, this is why a field "co-authored-by:" is a nice middle ground that allows for providing partial credit to the original author while maintaining maintainer's freedom to rewrite the whole damn thing.
- yencabulator 3y agoLinux does not use Co-authored-by. There was no Signed-off-by in the original patch, and the rules say Co-developed-by also requires a Signed-off-by. It was a security issue and was fixed ASAP, not waiting to hear back from the submitter. https://kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by https://kernel.org/doc/html/latest/process/submitting-patche...
- phendrenad2 3y ago> the proposed fix wasn't good enough That hasn't been proven, we need to see the patches.
- arghwhat 3y ago> That hasn't been proven It was decided by the maintainer, the only person who can make the decision. > we need to see the patches. ... they are linked in the post.