5 ms·
I see multiple people saying the authors fix was in a way inferior. Where is this mentioned?
by ghosty141 3y ago
I see multiple people saying the authors fix was in a way inferior. Where is this mentioned?
- toyg 3y agoIt was stated by the maintainer as the reason for discarding the author's contribution.
- Sprocklem 3y agoWhat the maintainer actually said was [0]: > Thanks for your patch, but I wanted to fix it differently. Can you try the patch below and make sure it fixes the bug for you? Which to me, at least, reads very differently than claiming the author's patch is worse. [0] https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/244387.html https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/24... (Credit to nolist_policy for pointing this out upthread.)
- shakow 3y agoWe can't really know as we can't see the author's patch, but given that (i) the guy answering is responsible for the whole CPU architecture in Linux and (ii) the author mourns his putative contributor badge but does not criticize the other patch, that's a bet I'm ready to take.
- hnfong 3y agoFYI https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/244438.html https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/24... https://lore.kernel.org/all/20220609133245.573565-1-mpe@ellerman.id.au/ https://lore.kernel.org/all/20220609133245.573565-1-mpe@elle...
- cortesoft 3y agoObviously the author is not going to say their fix was worse, but commenters on here have described why: https://news.ycombinator.com/item?id=37675544 https://news.ycombinator.com/item?id=37675544
- ariel-miculas 3y agosee https://news.ycombinator.com/item?id=37692883 https://news.ycombinator.com/item?id=37692883