3 ms·

> I'd be pissed if I put in a lot of effort revising my contributions to a project, only to be told at the end that "I like my version better, so go away!" Fra

by shakow 3y ago

> I'd be pissed if I put in a lot of effort revising my contributions to a project, only to be told at the end that "I like my version better, so go away!" Frankly, I think that's a non-trivial problem to solve: how to get the assumedly better fix while not ruffling the feathers of the more junior contributor so not to discourage on-ramping. I guess the best way to do it would be to have a co-authored-by tag, or something akin.

ghosty141 3y ago
I see multiple people saying the authors fix was in a way inferior. Where is this mentioned?
- toyg 3y ago
  It was stated by the maintainer as the reason for discarding the author's contribution.
  - Sprocklem 3y ago
    What the maintainer actually said was [0]: > Thanks for your patch, but I wanted to fix it differently. Can you try the patch below and make sure it fixes the bug for you? Which to me, at least, reads very differently than claiming the author's patch is worse. [0] https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/244387.html https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/24... (Credit to nolist_policy for pointing this out upthread.)
- shakow 3y ago
  We can't really know as we can't see the author's patch, but given that (i) the guy answering is responsible for the whole CPU architecture in Linux and (ii) the author mourns his putative contributor badge but does not criticize the other patch, that's a bet I'm ready to take.
  - hnfong 3y ago
    FYI https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/244438.html https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/24... https://lore.kernel.org/all/20220609133245.573565-1-mpe@ellerman.id.au/ https://lore.kernel.org/all/20220609133245.573565-1-mpe@elle...
- cortesoft 3y ago
  Obviously the author is not going to say their fix was worse, but commenters on here have described why: https://news.ycombinator.com/item?id=37675544 https://news.ycombinator.com/item?id=37675544
  - ariel-miculas 3y ago
    see https://news.ycombinator.com/item?id=37692883 https://news.ycombinator.com/item?id=37692883
hmottestad 3y ago
A pull request and some comments to help the author understand what needs to be adjusted is a common way to handle this with the projects that I work with.

by shakow 3y ago

ghosty141 3y ago

I see multiple people saying the authors fix was in a way inferior. Where is this mentioned?

toyg 3y ago
It was stated by the maintainer as the reason for discarding the author's contribution.
- Sprocklem 3y ago
  What the maintainer actually said was [0]: > Thanks for your patch, but I wanted to fix it differently. Can you try the patch below and make sure it fixes the bug for you? Which to me, at least, reads very differently than claiming the author's patch is worse. [0] https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/244387.html https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/24... (Credit to nolist_policy for pointing this out upthread.)
shakow 3y ago
We can't really know as we can't see the author's patch, but given that (i) the guy answering is responsible for the whole CPU architecture in Linux and (ii) the author mourns his putative contributor badge but does not criticize the other patch, that's a bet I'm ready to take.
- hnfong 3y ago
  FYI https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/244438.html https://lists.ozlabs.org/pipermail/linuxppc-dev/2022-June/24... https://lore.kernel.org/all/20220609133245.573565-1-mpe@ellerman.id.au/ https://lore.kernel.org/all/20220609133245.573565-1-mpe@elle...
cortesoft 3y ago
Obviously the author is not going to say their fix was worse, but commenters on here have described why: https://news.ycombinator.com/item?id=37675544 https://news.ycombinator.com/item?id=37675544
- ariel-miculas 3y ago
  see https://news.ycombinator.com/item?id=37692883 https://news.ycombinator.com/item?id=37692883

hmottestad 3y ago

A pull request and some comments to help the author understand what needs to be adjusted is a common way to handle this with the projects that I work with.