3 ms·
Depends. What's the goal? Get the PR merge as quick as possible to keep momentum going on a project or nit pick over details that are "just like your opinion, m
by andrewfromx 3y ago
Depends. What's the goal? Get the PR merge as quick as possible to keep momentum going on a project or nit pick over details that are "just like your opinion, man" and try for the never ending quest of perfect code.
- baristaGeek 3y agoWhat we argue is that code review's goal is not only preventing the deployment of bad code to production (very important by itself) but also osmote information about the codebase to everyone on the team.
- andrewfromx 3y agoyeah but how do you prevent egos and personalities to dominate and have it not turn into "well bob said do it this way and I'm in bob's camp." "Oh yeah, bob doesn't know what he's talking about..." not the mention the subtle stuff going on behind the scenes not talked about. Some people are friends outside of work and are having a fight that has nothing to do with the code but taking it out on each other in the PR! https://www.stilldrinking.org/programming-sucks https://www.stilldrinking.org/programming-sucks