3 ms·
Another practical issue with trunk-based development is that most code review tools only support reviewing complete branches and don't support reviewing a bunch
by sebazzz 3y ago
Another practical issue with trunk-based development is that most code review tools only support reviewing complete branches and don't support reviewing a bunch of individual commits. Well, Jetbrains Upsource supports it, but unfortunately that has been canned by Jetbrains.
However, trunk-based development allows high-paced development of applications, and testers can easily review the combined result on a test environment.
- gettodachoppa 3y agoWhy would you want to review individual commits when the same lines can change from one commit to another? It seems like more work. Personally I want to see the final list of changes when I review, and not waste my time with intermediate stuff. I know some people are diligent about using rebase to present a clean commit history, but that's rare in practice in my experience. And it's incompatible with devs who aren't skilled at git.
- sebazzz 3y agoThat's why I said "a bunch of individual [related] commits"