3 ms·
Personally as an open source maintainer I like the typo/wording fixes/automated refactor PRs the most. There's almost no effort needed from my side to review th
by JelteF 3y ago
Personally as an open source maintainer I like the typo/wording fixes/automated refactor PRs the most. There's almost no effort needed from my side to review them, so I almost always merge those very quickly. It's the PRs that implement huge are the ones that you take the most time reviewing/discussing, and thus those are the ones I put off looking closely at.
- EdwardDiego 3y agoThe submitter creating multiple var -> let PRs (one PR per file...), was also doing this, including the one file per PR, in other projects, and would've broken some of their legacy IE(!) users. https://github.com/MithrilJS/mithril.js/pull/2880#pullrequestreview-1607584605 https://github.com/MithrilJS/mithril.js/pull/2880#pullreques... That's a particularly obnoxious bot. Didnt even follow their workflow... I suppose it depends on scale, and the team size. And Github issues are 80% support forums, 20% bugs, 5% of the bugs come with reproduction test cases, if you're lucky.
- JelteF 3y agoYeah, okay of course you can take it to far. But in the general case I would not want to discourage people from opening "trivial" PRs. Since those are the PRs that cost me the least time to manage, while still improving the project (even if it's by a small amount).