4 ms·
I see your point but the article says this: > This property was then used when logging visible Tweets that it was in fact displayed. It was a relational ID tha
by mostlysimilar 3y ago
I see your point but the article says this:
> This property was then used when logging visible Tweets that it was in fact displayed. It was a relational ID that told the backend systems exactly which Tweet from which advertiser was being displayed.
It was supposed to be storing these IDs. Did nobody think to test that the thing was, in fact, storing IDs? Especially for something that puts hundreds of thousands of dollars on the line? Even if you're actually passing that value off to some 3rd party system somewhere, you can verify that this slice of your problem (the React component that receives a prop) is doing its job properly. Even if that means stubbing it to log locally. Something?
- doctor_eval 3y agoThe problem is that in a large system like Twitter, the backend code that stored the ID is very distant from the front end code that generated the tag. I’m not defending this or anything, but you said that this should have been manually tested, and I’m just observing that manually testing a system as complex as Twitter, in any kind of comprehensive way, is not at all trivial.
- mostlysimilar 3y agoI get you and that makes sense, and we're discussing things at a scale that I don't have experience with. I just wouldn't have been comfortable shipping this code without observing it functioning in some way. If your production environment is so complex that you can't properly test things locally then you should certainly have a staging environment that makes that kind of testing possible. I would never be satisfied doing zero manual testing of the code I ship.