4 ms·

Source? Maybe in some scenarios it shows a fault that is absolutely unnoticeable, but every real world case I've seen was at least theoretically noticeable by

Source? Maybe in some scenarios it shows a fault that is absolutely unnoticeable, but every real world case I've seen was at least theoretically noticeable by the user.

nemo 3y ago
My system's running fine with no noticeable issues. I opened Console to check for faults and after running with logging on I eventually got a couple, all tied to Safari trying to read a preference from a domain it didn't have permissions to. No performance issues or other user-detectable impacts.
- MichaelZuo 3y ago
  'Safari trying to read a preference from a domain it didn't have permissions to.' That doesn't sound like normal behaviour, what's the domain?
  - nemo 3y ago
    It looks like a plug-in hitting some Preferences path it doesn't need to read as it iterates for its pref.
saagarjha 3y ago
The literal source code in this case: you can look up yourself how os_log_fault works.
- MichaelZuo 3y ago
  Can you link it?
  - saagarjha 3y ago
    #define os_log_fault(log, format, ...) \ os_log_with_type(log, OS_LOG_TYPE_FAULT, format, ##__VA_ARGS__) It's literally just an os_log with the "fault" type set. You can call it whenever you want. Most libraries have a couple sprinkled in for things that someone should probably check at some point but there is no actual semantics to it to mean that something is necessarily broken.
    - MichaelZuo 3y ago
      This doesn't seem to indicate what you suggest. Can you link proof that even a single real world application calls it whenever it wants? The mere fact that it's theoretically possible doesn't seem to be persuasive.
      - saagarjha 3y ago
        On the contrary, I find your position to be confusing. It's just a function that anyone can call. If you go on GitHub you can see many people who are using it for whatever logging they think is appropriate. Why do you think it has anything to do with correctness? This isn't like a crash or a OOM where you're generally pretty sure something is seriously wrong, because you can just trigger this whenever you want.
        MichaelZuo 3y ago
        Then it would only take you a minute to link an example or two?

Source? Maybe in some scenarios it shows a fault that is absolutely unnoticeable, but every real world case I've seen was at least theoretically noticeable by the user.

nemo 3y ago

My system's running fine with no noticeable issues. I opened Console to check for faults and after running with logging on I eventually got a couple, all tied to Safari trying to read a preference from a domain it didn't have permissions to. No performance issues or other user-detectable impacts.

MichaelZuo 3y ago
'Safari trying to read a preference from a domain it didn't have permissions to.' That doesn't sound like normal behaviour, what's the domain?
- nemo 3y ago
  It looks like a plug-in hitting some Preferences path it doesn't need to read as it iterates for its pref.

saagarjha 3y ago

The literal source code in this case: you can look up yourself how os_log_fault works.

MichaelZuo 3y ago
Can you link it?
- saagarjha 3y ago
  #define os_log_fault(log, format, ...) \ os_log_with_type(log, OS_LOG_TYPE_FAULT, format, ##__VA_ARGS__) It's literally just an os_log with the "fault" type set. You can call it whenever you want. Most libraries have a couple sprinkled in for things that someone should probably check at some point but there is no actual semantics to it to mean that something is necessarily broken.
  - MichaelZuo 3y ago
    This doesn't seem to indicate what you suggest. Can you link proof that even a single real world application calls it whenever it wants? The mere fact that it's theoretically possible doesn't seem to be persuasive.
    - saagarjha 3y ago
      On the contrary, I find your position to be confusing. It's just a function that anyone can call. If you go on GitHub you can see many people who are using it for whatever logging they think is appropriate. Why do you think it has anything to do with correctness? This isn't like a crash or a OOM where you're generally pretty sure something is seriously wrong, because you can just trigger this whenever you want.
      - MichaelZuo 3y ago
        Then it would only take you a minute to link an example or two?