3 ms·
I just checked the source and openssh doesn't appear to set madvise(MADV_DONTDUMP) anywhere :-( That seems like an oversight? For comparison openssl has a set
by rwmj 3y ago
I just checked the source and openssh doesn't appear to set madvise(MADV_DONTDUMP) anywhere :-( That seems like an oversight? For comparison openssl has a set of "secure malloc" functions (for keys etc) which uses MADV_DONTDUMP amongst other mitigations.
- garblegarble 3y agoInterestingly, it looks like ssh-agent disables core dumps[1], but I don't see similar usage for sshd 1: https://github.com/openssh/openssh-portable/blob/694150ad92765574ff82a18f4e86322bd3231e68/ssh-agent.c#L2248 https://github.com/openssh/openssh-portable/blob/694150ad927...
- Lt_Riza_Hawkeye 3y agosshd runs as root, so the core dumps would be readable as root-only, no? If you have root access already you could dump it even while it's still running with ptrace anyways
- garblegarble 3y ago>sshd runs as root, so the core dumps would be readable as root-only, no Yes, although the article we're discussing shows that you can't rely on that, the dump could be subsequently moved to a developer machine for investigation, and unencrypted key material left in could be compromised that way... defense in depth would make sense here.
- tedunangst 3y agoOn OpenBSD, you'd be looking for MAP_CONCEAL, though it's not used in many places, either.