2 ms·
I mean, I guess? Some people like small commits, and most of them looked reasonable to me (renaming one thing at a time); criticizing commit style seems like bi
by yjftsjthsd-h 3y ago
I mean, I guess? Some people like small commits, and most of them looked reasonable to me (renaming one thing at a time); criticizing commit style seems like bike-shedding, anyways.
- alexchantavy 3y agoAgree. I guess it’s different styles but when reviewing code I’ll look at the whole PR and almost never go commit by commit. If you expect OSS contributors to have perfect git hygiene, your project will never get contributors. If a breaking change is introduced, revert the offending PR as a whole.