3 ms·
I think that's exactly it, a 'straightforward rename' shouldn't consist of 20 commits with crap messages including 'missed that' (+ merge commit). But tonnes o
by OJFord 3y ago
I think that's exactly it, a 'straightforward rename' shouldn't consist of 20 commits with crap messages including 'missed that' (+ merge commit).
But tonnes of people don't care about git hygiene or using tools well in general, GP's in for an exhausting time caring about it much in projects they're not in control of.
- yjftsjthsd-h 3y agoI mean, I guess? Some people like small commits, and most of them looked reasonable to me (renaming one thing at a time); criticizing commit style seems like bike-shedding, anyways.
- alexchantavy 3y agoAgree. I guess it’s different styles but when reviewing code I’ll look at the whole PR and almost never go commit by commit. If you expect OSS contributors to have perfect git hygiene, your project will never get contributors. If a breaking change is introduced, revert the offending PR as a whole.