3 ms·

Good point, we should enforce squash merging.

Foxboron 3y ago
It would be trivial to at least continue the standards set by the terraform project. Now there are commits messing with `internal/backend` that breaks tests with the commit message "more". Someone is going to hit this with `git bisect` and it wont be their lucky day.
- fishnchips 3y ago
  Fair point, I think we can fix that. Thanks for highlighting that.
  - linuxdude314 3y ago
    [flagged]
    - jefftk 3y ago
      Be nice! They're just taking this on, and not already having sorted out whether they'll work with "all PR commits must have good messages and pass tests" vs "all PRs must be squashed" is the kind of minor issue you see with teams starting this sort of thing.
    - joshmanders 3y ago
      Ah yes, not having a compatible license that won't cause you legal troubles isn't why people pay for software its... checks notes the commit messages used in a PR.
    - laurels-marts 3y ago
      There's a difference between constructive feedback and toxic. Your comment falls in the latter category.
    - fishnchips 3y ago
      I know that you're commenting in bad faith and if it weren't for commit messages, you'd have found some other reason to spew hate. But I know that your comment will be read by people who don't come with an agenda, so I'll give it a try. > Do you not see how it’s problematic that you have these oversights? I do. We do. Note that none of the OpenTF folks downplayed it. We acknowledged. We will fix the process. We will move on. In my book, that's how mature people and organizations react. Mistakes are unavoidable, important is how you deal with them. The alternative I suppose would be to collectively fall on our swords because some committers from one company had a different style of working, and the tech lead from another company took his way of working for granted. I don't think we can continue living with this shame. > What reason would anyone ever trust your organization over Hashicorp? NONE! Don't trust us - watch us. Point out mistakes, too. Be a part of it, help us get better. > focused on PR (...) actual substance Like commits not squashed? What other substance are you missing from a spontaneously formed group that's been working together for a little over two weeks?
- Groxx 3y ago
  Anyone bisecting with a repo that uses merges should be aware of the `--first-parent` flag by this point. Or if not: you're welcome!

It would be trivial to at least continue the standards set by the terraform project. Now there are commits messing with `internal/backend` that breaks tests with the commit message "more". Someone is going to hit this with `git bisect` and it wont be their lucky day.

fishnchips 3y ago
Fair point, I think we can fix that. Thanks for highlighting that.
- linuxdude314 3y ago
  [flagged]
  - jefftk 3y ago
    Be nice! They're just taking this on, and not already having sorted out whether they'll work with "all PR commits must have good messages and pass tests" vs "all PRs must be squashed" is the kind of minor issue you see with teams starting this sort of thing.
  - joshmanders 3y ago
    Ah yes, not having a compatible license that won't cause you legal troubles isn't why people pay for software its... checks notes the commit messages used in a PR.
  - laurels-marts 3y ago
    There's a difference between constructive feedback and toxic. Your comment falls in the latter category.
  - fishnchips 3y ago
    I know that you're commenting in bad faith and if it weren't for commit messages, you'd have found some other reason to spew hate. But I know that your comment will be read by people who don't come with an agenda, so I'll give it a try. > Do you not see how it’s problematic that you have these oversights? I do. We do. Note that none of the OpenTF folks downplayed it. We acknowledged. We will fix the process. We will move on. In my book, that's how mature people and organizations react. Mistakes are unavoidable, important is how you deal with them. The alternative I suppose would be to collectively fall on our swords because some committers from one company had a different style of working, and the tech lead from another company took his way of working for granted. I don't think we can continue living with this shame. > What reason would anyone ever trust your organization over Hashicorp? NONE! Don't trust us - watch us. Point out mistakes, too. Be a part of it, help us get better. > focused on PR (...) actual substance Like commits not squashed? What other substance are you missing from a spontaneously formed group that's been working together for a little over two weeks?
Groxx 3y ago
Anyone bisecting with a repo that uses merges should be aware of the `--first-parent` flag by this point. Or if not: you're welcome!