3 ms·
"You don't need to add an external dependency for that" "You're violating separation of concerns" I've found that kind of feedback to be useful actually. And
by hn72774 3y ago
"You don't need to add an external dependency for that"
"You're violating separation of concerns"
I've found that kind of feedback to be useful actually. And when giving similar feedback it is received better with a small change in wording to make it more about the code and not the person. Even if that is the intention the wording does matter. For example:
"An external dependency isn't needed here, try implementing with XYZ instead."
"Split this function into x and y for better separation of concerns"
Removing the "you" removes some resistance to receiving the message .
- ted_bunny 3y agoThe imperative can rankle too. I like passive voice or "let's" statements.
- AgentOrange1234 3y agoYes always “we,” never “you.” I’ve become fond of mostly asking questions. I wonder if we could avoid this dependency? Maybe [idea] would work? Can you see a way to separate the X concern into a module? Can we split this function up a bit so the nesting won’t be so deep? Would this loop body make a good standalone function?
- hn72774 3y agoLove this, it's the Socratic method and leads to a better path without telling someone "how" to do their job.