4 ms·

I personally don't want to go back and forth between pages when they include hundreds of comments. Inline loading of comments is the much better, smarter altern

I personally don't want to go back and forth between pages when they include hundreds of comments. Inline loading of comments is the much better, smarter alternative. The last comments are loaded, you just gotta hit the page down key. The only thing that isn't loaded are the middle comments, and all you have to do there is tap load more comments link. Yeah, a company that does over a billion API requests per day, they're not going to load 500 comments on a page, if you need that and I don't think you do, use the API, it has pagination...

benatkin 3y ago
I agree with you. As someone who agrees with the other thread that the new pages for displaying code are a step backwards, I think that the issue pages are quite good.
38 3y ago
> Inline loading of comments is the much better, smarter alternative. with pagination, each page has a fixed number of comments, which means an expected amount of memory/CPU/network transfer. with inline loading, everything is loaded into the current page, which means the CPU and memory use essentially become unbounded, so the more you load the slower it goes. > The last comments are loaded, you just gotta hit the page down key. that's not how GitHub works. as I mentioned in the previous comment, this hidden comments are in the MIDDLE of the page, so page down doesn't make any sense here. > The only thing that isn't loaded are the middle comments, and all you have to do there is tap load more comments link. this only loads 60 comments, so in the example page I linked you'd need to: 1. click load more 2. scroll down until you find the end of the 60 new comments and then repeat this process 7 more times. with pagination, the page links are always at the bottom, not randomly in the middle of the page, making for faster navigation. > Yeah, a company that does over a billion API requests per day, they're not going to load 500 comments on a page no one is asking them to do that. that's what the current system allows for. I am asking for pagination, which would split all the comments across pages, which would only be loaded on request.
- bastardoperator 3y ago
  You're wrong, sorry, it's very obvious to see using your browser tools that GitHub is in fact requesting those records when the link is clicked versus loading every comment: load_more?after_cursor Where do we see cursors? Typically in pagination. So it's obvious if you want to see everything and load everything, you can do so and it's devoid of javascript so you can ctrl-f all day. https://github.com/golang/go/issues/21498/partials/load_more https://github.com/golang/go/issues/21498/partials/load_more You get pagination in both API's, go write some code.
  - 38 3y ago
    > You get pagination in both API's, go write some code. you seem to be making my own point for me. you're essentially saying, the website is so terrible, that users need to write their own frontend to make it usable. I agree!
    - bastardoperator 3y ago
      No, I pointed out why you're wrong so you're moving the goalposts. You can get at all the data and instead of seeing the value in that, you rather complain about how terrible things are how stupid young people are. If anything, at this point I feel bad y'all are having problems clicking links.
      - 38 3y ago
        > I feel bad y'all are having problems clicking links They aren't even links. They are buttons that trigger JavaScript which makes a network request. That's quite different from an actual link that just loads some html
inferiorhuman 3y ago
Yeah, hiding the comments makes searching the issues nearly impossible. If your search term is in one of the hidden comments then it's click... wait... search... click... wait... search as you load all the comments. Imagine how much easier life would be if GH just paginated the comments. No thanks. Infinite scrolling is never the answer.
- bastardoperator 3y ago
  I don't have that problem and if I did I would use the tools available to me to find what I wan't like the / command on every github page, or the gh cli tool: gh issue view 21498 -c Which loads every comment and gives you grep or rg for your searching pleasure. I hope your life is easier now. Also, Lazy loading is pagination. You're getting the best of both worlds, you're not loading everything, and you never have to go back. I'm not understanding the problem people are having here at all.
  - 38 3y ago
    > Also, Lazy loading is pagination. You're getting the best of both worlds, you're not loading everything, and you never have to go back. you're getting the worst of both worlds. you cant see everything at once, the load more is in a random spot in the middle of the page, and its impossible to load everything at once. compared to pagination, where you can jump to any random page you want. you just click the page number and boom it loads. I think we are looking at a culture clash, where younger people who dont have any actual experience with true pagination are trying to comment on it. if you had experience, you would know that its worlds better than whatever hellscape we currently have.
    - bastardoperator 3y ago
      You can, I posted the link in different comment, you can load everything, but you haven't bothered to look or explore, but using pagination means you never seen everything anyways. I don't think most people come across a 500 comment issue and need to start in the middle. They're reading top down and expanding as they get deeper into the conversation. They're literally using pagination to display the issues, you can see it yourself. You think I'm a younger person because I disagree with you? That's classic. You're the only one I see complaining, I have no issues with it. If anything it sounds like you don't understand GitHub and you're unwilling to learn anything new or or even try to overcome your old and decrepit ways with tools that are readily available and simple to use. Whatever..., btw I'm well over the hill.

benatkin 3y ago

I agree with you. As someone who agrees with the other thread that the new pages for displaying code are a step backwards, I think that the issue pages are quite good.

38 3y ago

> Inline loading of comments is the much better, smarter alternative. with pagination, each page has a fixed number of comments, which means an expected amount of memory/CPU/network transfer. with inline loading, everything is loaded into the current page, which means the CPU and memory use essentially become unbounded, so the more you load the slower it goes. > The last comments are loaded, you just gotta hit the page down key. that's not how GitHub works. as I mentioned in the previous comment, this hidden comments are in the MIDDLE of the page, so page down doesn't make any sense here. > The only thing that isn't loaded are the middle comments, and all you have to do there is tap load more comments link. this only loads 60 comments, so in the example page I linked you'd need to: 1. click load more 2. scroll down until you find the end of the 60 new comments and then repeat this process 7 more times. with pagination, the page links are always at the bottom, not randomly in the middle of the page, making for faster navigation. > Yeah, a company that does over a billion API requests per day, they're not going to load 500 comments on a page no one is asking them to do that. that's what the current system allows for. I am asking for pagination, which would split all the comments across pages, which would only be loaded on request.

bastardoperator 3y ago
You're wrong, sorry, it's very obvious to see using your browser tools that GitHub is in fact requesting those records when the link is clicked versus loading every comment: load_more?after_cursor Where do we see cursors? Typically in pagination. So it's obvious if you want to see everything and load everything, you can do so and it's devoid of javascript so you can ctrl-f all day. https://github.com/golang/go/issues/21498/partials/load_more https://github.com/golang/go/issues/21498/partials/load_more You get pagination in both API's, go write some code.
- 38 3y ago
  > You get pagination in both API's, go write some code. you seem to be making my own point for me. you're essentially saying, the website is so terrible, that users need to write their own frontend to make it usable. I agree!
  - bastardoperator 3y ago
    No, I pointed out why you're wrong so you're moving the goalposts. You can get at all the data and instead of seeing the value in that, you rather complain about how terrible things are how stupid young people are. If anything, at this point I feel bad y'all are having problems clicking links.
    - 38 3y ago
      > I feel bad y'all are having problems clicking links They aren't even links. They are buttons that trigger JavaScript which makes a network request. That's quite different from an actual link that just loads some html

inferiorhuman 3y ago

Yeah, hiding the comments makes searching the issues nearly impossible. If your search term is in one of the hidden comments then it's click... wait... search... click... wait... search as you load all the comments. Imagine how much easier life would be if GH just paginated the comments. No thanks. Infinite scrolling is never the answer.

bastardoperator 3y ago
I don't have that problem and if I did I would use the tools available to me to find what I wan't like the / command on every github page, or the gh cli tool: gh issue view 21498 -c Which loads every comment and gives you grep or rg for your searching pleasure. I hope your life is easier now. Also, Lazy loading is pagination. You're getting the best of both worlds, you're not loading everything, and you never have to go back. I'm not understanding the problem people are having here at all.
- 38 3y ago
  > Also, Lazy loading is pagination. You're getting the best of both worlds, you're not loading everything, and you never have to go back. you're getting the worst of both worlds. you cant see everything at once, the load more is in a random spot in the middle of the page, and its impossible to load everything at once. compared to pagination, where you can jump to any random page you want. you just click the page number and boom it loads. I think we are looking at a culture clash, where younger people who dont have any actual experience with true pagination are trying to comment on it. if you had experience, you would know that its worlds better than whatever hellscape we currently have.
  - bastardoperator 3y ago
    You can, I posted the link in different comment, you can load everything, but you haven't bothered to look or explore, but using pagination means you never seen everything anyways. I don't think most people come across a 500 comment issue and need to start in the middle. They're reading top down and expanding as they get deeper into the conversation. They're literally using pagination to display the issues, you can see it yourself. You think I'm a younger person because I disagree with you? That's classic. You're the only one I see complaining, I have no issues with it. If anything it sounds like you don't understand GitHub and you're unwilling to learn anything new or or even try to overcome your old and decrepit ways with tools that are readily available and simple to use. Whatever..., btw I'm well over the hill.