their tablegen still munges the trees manually. a proper tablegen would give easy to write lhs -> rhs tree rules, and doesn"t allow shooting yourself into your

their tablegen still munges the trees manually. a proper tablegen would give easy to write lhs -> rhs tree rules, and doesn"t allow shooting yourself into your foot. see proper lisp/scheme matchers. even the gimple matcher hack is far better see eg. https://github.com/j2kun/mlir-tutorial/blob/92723e224c1a6e8cdffc1183dd993a1114a31b07/lib/Transform/Arith/MulToAdd.cpp#L19 https://github.com/j2kun/mlir-tutorial/blob/92723e224c1a6e8c...