4 ms·

Of all the Google dev tools, I miss Critique the most. GitHub is terrible at giving enough context to efficiently review a PR on a second or third pass. I thin

by sa46 3y ago

Of all the Google dev tools, I miss Critique the most. GitHub is terrible at giving enough context to efficiently review a PR on a second or third pass. I think coupling commits with review progress was a mistake.

codeapprove 3y ago
Shameless plug but if you're missing Critique and working on GitHub, try CodeApprove (https://codeapprove.com https://codeapprove.com) which brings as much of the Critique magic to GitHub as possible.
- limonkufu 3y ago
  This seems very simiilar to Gitlab's MR. Does anyone know all of them to highlight their strengths and drawbacks?
- darkwater 3y ago
  Offtopic but, aren't you scared by "GitHub improves its PR workflow" and put your product out of business?
  - codeapprove 3y ago
    Yes that's a real risk! CodeApprove is not (yet) anyone's full time job so it's also an acceptable risk. However I think the biggest issue with the landscape for code review tools is that 99% of developers use the default system that ships with their VCS. So on most teams, that's GitHub. People should be actively choosing their code review tools just like they choose their VCS, IDE, CI/CD platform, Issue Trackers, etc. It's one of many tools that makes up your SDLC "Stack".
  - underdeserver 3y ago
    They haven't done it yet. What's been stopping them? As long as CodeApprove and Reviewable remain niche they've got nothing to worry about.
nh2 3y ago
https://reviewable.io https://reviewable.io is the earliest full-powered Critique alternative for GitHub. It supports some cool things Critique doesn't/didn't, such as reviewing multi-commit branches (also across history-rewriting force-push cleanups), and indicating exactly the nature of your comment (just FYI, or you want this to be changed before you'll give your approval). (I was an intern in the initial making of Critique, and subsequently got interested in finding an out-of-Google alternative. I contributed a bit to other review tools such as ReviewBoard, and actively used Gerrit, Crucible, Phabricator, and GitLab reviews.) When looking for a Critique alternative for my startup, reviewable.io had just appeared and ticked all the boxes, and we use it successfully for many years. The drawbacks are that it's GitHub-only and isn't free software.

by sa46 3y ago

codeapprove 3y ago

Shameless plug but if you're missing Critique and working on GitHub, try CodeApprove (https://codeapprove.com https://codeapprove.com) which brings as much of the Critique magic to GitHub as possible.

limonkufu 3y ago
This seems very simiilar to Gitlab's MR. Does anyone know all of them to highlight their strengths and drawbacks?
darkwater 3y ago
Offtopic but, aren't you scared by "GitHub improves its PR workflow" and put your product out of business?
- codeapprove 3y ago
  Yes that's a real risk! CodeApprove is not (yet) anyone's full time job so it's also an acceptable risk. However I think the biggest issue with the landscape for code review tools is that 99% of developers use the default system that ships with their VCS. So on most teams, that's GitHub. People should be actively choosing their code review tools just like they choose their VCS, IDE, CI/CD platform, Issue Trackers, etc. It's one of many tools that makes up your SDLC "Stack".
- underdeserver 3y ago
  They haven't done it yet. What's been stopping them? As long as CodeApprove and Reviewable remain niche they've got nothing to worry about.

nh2 3y ago

https://reviewable.io https://reviewable.io is the earliest full-powered Critique alternative for GitHub. It supports some cool things Critique doesn't/didn't, such as reviewing multi-commit branches (also across history-rewriting force-push cleanups), and indicating exactly the nature of your comment (just FYI, or you want this to be changed before you'll give your approval). (I was an intern in the initial making of Critique, and subsequently got interested in finding an out-of-Google alternative. I contributed a bit to other review tools such as ReviewBoard, and actively used Gerrit, Crucible, Phabricator, and GitLab reviews.) When looking for a Critique alternative for my startup, reviewable.io had just appeared and ticked all the boxes, and we use it successfully for many years. The drawbacks are that it's GitHub-only and isn't free software.